Display labels in sentence case, rename Windows type to Windows audience#1332
Merged
Display labels in sentence case, rename Windows type to Windows audience#1332
Conversation
maebeale
force-pushed
the
maebeale/sentence-case-labels
branch
from
ff02f6f to
25718d5
Compare
maebeale
commented
Mar 4, 2026
| age_range_order = ["3-5", "6-12", "13-17", "18+", "Mixed-age groups", "Family windows"] | ||
| age_range_order.each_with_index do |name, i| | ||
| Category.where("LOWER(name) = LOWER(?)", name).update_all(position: i + 1) | ||
| end |
Collaborator
Author
There was a problem hiding this comment.
adding position to age range seeds so they match prod
maebeale
changed the title
Replace .titleize with .humanize for category type display so labels render as sentence case (e.g. "Art type" instead of "Art Type"). Rename all user-facing "Windows type" / "Windows Type" strings to "Windows audience" for consistency with the updated terminology. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
- Fix RuboCop SpaceInsideArrayLiteralBrackets in seeds.rb - Update workshops system specs: "Windows Audience" → "Windows audience" - Update stories view spec: "Age Range" → "Age range" - Update person filters test: "Windows Type" → "Windows audience" Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
.humanize alone turns "AgeRange" into "Agerange". Adding .underscore first converts to "age_range", then .humanize produces "Age range". Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/sentence-case-labels
branch
from
d5cf0fe to
02b45a0
Compare
maebeale
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the goal of this PR and why is this important?
How did you approach the change?
.titleizewith.humanizeinCategoryTypeDecorator#title,CategoryType#display_label, and the_dropdown_filterpartial so labels render as sentence case (e.g. "Art type" not "Art Type")UI Testing Checklist
Anything else to add?
workshops/_form.html.erbandworkshop_ideas/_form.html.erb) already had "Windows audience" from a prior change🤖 Generated with Claude Code